Skip to content

doc: stream.isReadable and stream.isWritable API fixups #59089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 6 commits into from
Sep 7, 2025
Merged

doc: stream.isReadable and stream.isWritable API fixups #59089

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c2bcc6f
lib: fix isReadable and isWritable return type value
joaoGabriel55 Jul 16, 2025
53c228b
test: write test-streem-utils.js test file
joaoGabriel55 Jul 16, 2025
4e040c1
rollback: undo the last change and delete the unnecessary test
joaoGabriel55 Jul 17, 2025
301d58c
doc: update isReadable and add isWritable doc
joaoGabriel55 Jul 17, 2025
844b176
lint: run make lint-js
joaoGabriel55 Jul 17, 2025
5e4640d
doc: clarify return values for isReadable and isWritable functions
joaoGabriel55 Jul 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
rollback: undo the last change and delete the unnecessary test
  • Loading branch information
@joaoGabriel55
joaoGabriel55 committed Jul 17, 2025
commit 4e040c17d2aef94f9a4c78f3ea12cba87754bccb
12 changes: 4 additions & 8 deletions lib/internal/streams/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,24 +172,20 @@ function isReadableFinished(stream, strict) {

function isReadable(stream) {
if (stream && stream[kIsReadable] != null) return stream[kIsReadable];
if (typeof stream?.readable !== 'boolean') return false;
if (typeof stream?.readable !== 'boolean') return null;
if (isDestroyed(stream)) return false;
return Boolean(
isReadableNodeStream(stream) &&
return isReadableNodeStream(stream) &&
stream.readable &&
!isReadableFinished(stream)
Comment thread
joaoGabriel55 marked this conversation as resolved.
Outdated
);
}

function isWritable(stream) {
if (stream && stream[kIsWritable] != null) return stream[kIsWritable];
if (typeof stream?.writable !== 'boolean') return false
if (typeof stream?.writable !== 'boolean') return null
Comment thread
joaoGabriel55 marked this conversation as resolved.
Outdated
if (isDestroyed(stream)) return false;
return Boolean(
isWritableNodeStream(stream) &&
return isWritableNodeStream(stream) &&
stream.writable &&
!isWritableEnded(stream)
Comment thread
joaoGabriel55 marked this conversation as resolved.
Outdated
);
}

function isFinished(stream, opts) {
Expand Down
12 changes: 0 additions & 12 deletions test/parallel/test-stream-utils.js
View file
Open in desktop

This file was deleted.