dns: fix parse memory leaky

PR-URL: #58973 Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS · Jul 9, 2025 · Jun 24, 2025 · Jun 24, 2025 · Jun 23, 2025 · Jun 23, 2025
commit 3afb15b7153cbe74e0d23aee4e0445e7ee84809f
diff --git a/src/cares_wrap.cc b/src/cares_wrap.cc
@@ -1565,6 +1565,8 @@ Maybe<int> SoaTraits::Parse(QuerySoaWrap* wrap,
 
   if (status != ARES_SUCCESS) return Just<int>(status);
 
+  auto cleanup = OnScopeLeave([&]() { ares_free_data(soa_out); });
+
   Local<Object> soa_record = Object::New(env->isolate());
 
   if (soa_record
@@ -1605,8 +1607,6 @@ Maybe<int> SoaTraits::Parse(QuerySoaWrap* wrap,
     return Nothing<int>();
   }
 
-  ares_free_data(soa_out);
-
   wrap->CallOnComplete(soa_record);
   return Just<int>(ARES_SUCCESS);
 }