Skip to content

assert: allow printf-style messages as assertion error #58849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 5 commits into from
Oct 17, 2025
Merged

assert: allow printf-style messages as assertion error #58849

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
591a6e3
assert: allow printf-style messages as assertion error
BridgeAR Jun 26, 2025
32e43c2
fixup!
BridgeAR Oct 6, 2025
a41a7a5
fixup!
BridgeAR Oct 6, 2025
7dea1a2
fixup!
BridgeAR Oct 7, 2025
67d2b7b
fixup! add more tests
BridgeAR Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! add more tests
  • Loading branch information
@BridgeAR
BridgeAR committed Oct 7, 2025
commit 67d2b7b752ae3ff9159ace8ae6416d62e1940186
18 changes: 18 additions & 0 deletions test/parallel/test-assert.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1737,6 +1737,24 @@ test('Ambiguous error messages fail', () => {
);
});

test('Faulty message functions', () => {
assert.throws(
() => assert.doesNotMatch('foo', /foo/, (a, b) => 123),
{
code: 'ERR_ASSERTION',
message: "'foo' doesNotMatch /foo/"
}
);

assert.throws(
() => assert.match('foo', /123/, (a, b) => { new Error('baz'); }),
{
code: 'ERR_ASSERTION',
message: "'foo' match /123/"
}
);
});

test('Functions as error message', () => {
function errorMessage(actual, expected) {
return `Nice message including ${actual} and ${expected}`;
Expand Down
Loading