Skip to content

test_runner: fix timeout not propagated to the child process in run #58831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Jun 27, 2025
Merged

test_runner: fix timeout not propagated to the child process in run #58831

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a11e816
test_runner: fix timeout not propagated to the child process in run
jakecastelli Jun 25, 2025
7720b96
fixup! test
jakecastelli Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test_runner: fix timeout not propagated to the child process in run
  • Loading branch information
@jakecastelli
jakecastelli committed Jun 25, 2025
commit a11e81689395a7e3d6366272f67f02786913783a
4 changes: 4 additions & 0 deletions lib/internal/test_runner/runner.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@ function getRunArgs(path, { forceExit,
only,
argv: suppliedArgs,
execArgv,
root: { timeout },
cwd }) {
const argv = ArrayPrototypeFilter(process.execArgv, filterExecArgv);
if (forceExit === true) {
Expand All @@ -162,6 +163,9 @@ function getRunArgs(path, { forceExit,
if (only === true) {
ArrayPrototypePush(argv, '--test-only');
}
if (timeout != null) {
ArrayPrototypePush(argv, `--test-timeout=${timeout}`);
}

ArrayPrototypePushApply(argv, execArgv);

Expand Down
6 changes: 4 additions & 2 deletions test/parallel/test-runner-run.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,9 +88,11 @@ describe('require(\'node:test\').run', { concurrency: true }, () => {

it('should support timeout', async () => {
const stream = run({ timeout: 50, files: [
fixtures.path('test-runner', 'timeout-basic.mjs'),
fixtures.path('test-runner', 'plan', 'timeout-basic.mjs'),
] });
stream.on('test:fail', common.mustCall(1));
stream.on('test:fail', common.mustCall((data) => {
assert.strictEqual(data.details.error.failureType, 'testTimeoutFailure');
}));
stream.on('test:pass', common.mustNotCall());
// eslint-disable-next-line no-unused-vars
for await (const _ of stream);
Expand Down