Skip to content

deps: V8: cherry-pick 0ce2edb7adfd #58773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Jul 4, 2025
Merged

deps: V8: cherry-pick 0ce2edb7adfd #58773

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
deps: V8: cherry-pick 0ce2edb7adfd 
Original commit message:

    Fix invalid template specialization

    Bug: chromium:40565911
    Change-Id: If206c140e99e24a6df4ee7351e8022748eabac22
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6491420
    Auto-Submit: Bruno Pitrus <brunopitrus@hotmail.com>
    Commit-Queue: Jakob Linke <jgruber@chromium.org>
    Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    Reviewed-by: Jakob Linke <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#99987}

Refs: v8/v8@0ce2edb
Fixes: #58485
  • Loading branch information
@brjsp @targos
brjsp authored and targos committed Jul 3, 2025
commit 33b48c3b775fbe81015934aaf6cafac7dcb1f0c8
2 changes: 1 addition & 1 deletion common.gypi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.15',
'v8_embedder_string': '-node.16',

##### V8 defaults for Node.js #####

Expand Down
10 changes: 2 additions & 8 deletions deps/v8/src/codegen/riscv/macro-assembler-riscv.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,10 +406,7 @@ class V8_EXPORT_PRIVATE MacroAssembler : public MacroAssemblerBase {
push_helper(rs...);
}

template <>
void push_helper(Register r) {
StoreWord(r, MemOperand(sp, 0));
}
void push_helper() {}

public:
// Push a number of registers. The leftmost register first (to the highest
Expand Down Expand Up @@ -554,10 +551,7 @@ class V8_EXPORT_PRIVATE MacroAssembler : public MacroAssemblerBase {
LoadWord(r, MemOperand(sp, sizeof...(rs) * kSystemPointerSize));
}

template <>
void pop_helper(Register r) {
LoadWord(r, MemOperand(sp, 0));
}
void pop_helper() {}

public:
// Pop a number of registers. The leftmost register last (from the highest
Expand Down