Skip to content

test_runner: prefer Atomics primordials #58716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduh95 merged 1 commit into from
Jun 17, 2025
+4 −10
Merged

test_runner: prefer Atomics primordials #58716

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test_runner: prefer Atomics primordials 
PR-URL: #58716
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
  • Loading branch information
@Renegade334 @aduh95
Renegade334 authored and aduh95 committed Jun 17, 2025
commit ef2e0848ba366ca278d936f1f793d455188e792e
8 changes: 2 additions & 6 deletions lib/internal/test_runner/mock/loader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,9 @@
'use strict';
const {
AtomicsNotify,
AtomicsStore,
JSONStringify,
SafeMap,
globalThis: {
Atomics: {
notify: AtomicsNotify,
store: AtomicsStore,
},
},
} = primordials;
const {
kBadExportsMessage,
Expand Down
6 changes: 2 additions & 4 deletions lib/internal/test_runner/mock/mock.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
const {
ArrayPrototypePush,
ArrayPrototypeSlice,
AtomicsStore,
AtomicsWait,
Error,
FunctionPrototypeBind,
FunctionPrototypeCall,
Expand All @@ -18,10 +20,6 @@ const {
StringPrototypeSlice,
StringPrototypeStartsWith,
globalThis: {
Atomics: {
store: AtomicsStore,
wait: AtomicsWait,
},
SharedArrayBuffer,
},
} = primordials;
Expand Down