Skip to content

module: refactor commonjs typescript loader #58657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Jun 12, 2025
Merged

module: refactor commonjs typescript loader #58657

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12132fa
module: refactor commonjs typescript loader
marco-ippolito Jun 10, 2025
c942d9f
fix: linting
marco-ippolito Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: linting 
Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>
  • Loading branch information
@marco-ippolito @joyeecheung
marco-ippolito and joyeecheung authored Jun 10, 2025
commit c942d9fab7710463ba6f6bf2af29335959405307
2 changes: 1 addition & 1 deletion lib/internal/modules/cjs/loader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1816,7 +1816,7 @@ Module._extensions['.js'] = function(module, filename) {
const { source, format: loadedFormat } = loadSource(module, filename, format);
// Function require shouldn't be used in ES modules when require(esm) is disabled.
if ((loadedFormat === 'module' || loadedFormat === 'module-typescript') &&
!getOptionValue('--experimental-require-module')) {
!getOptionValue('--experimental-require-module')) {
const err = getRequireESMError(module, pkg, source, filename);
throw err;
}
Expand Down