Skip to content

module: correctly detect top-level await in ambiguous contexts #58646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 8 commits into from
Aug 15, 2025
Merged

module: correctly detect top-level await in ambiguous contexts #58646

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5d805a1
module: correctly detect top-level await in ambiguous contexts
islandryu Jun 9, 2025
a8a3a33
use std::array
islandryu Jun 10, 2025
9d6a322
move test
islandryu Jun 16, 2025
c4f371b
fix format
islandryu Jun 22, 2025
2b3000c
add test for unrelated error
islandryu Jun 29, 2025
a60b3e0
undo a test that has been erased
islandryu Jun 29, 2025
e65cc6c
fix lint
islandryu Jun 29, 2025
993bcfc
Update test/es-module/test-esm-tla-syntax-errors-not-recognized-as-tl…
islandryu Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update test/es-module/test-esm-tla-syntax-errors-not-recognized-as-tl… 
…a-error.mjs

Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>
  • Loading branch information
@islandryu @joyeecheung
islandryu and joyeecheung authored Jul 1, 2025
commit 993bcfc0b8698ce817292ed5784771f968d78829
2 changes: 1 addition & 1 deletion test/es-module/test-esm-tla-syntax-errors-not-recognized-as-tla-error.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { spawnPromisified } from '../common/index.mjs';
import { describe, it } from 'node:test';
import { strictEqual, match } from 'node:assert';

describe('maybe top-level await syntax errors that are not recognized as top-level await errors', () => {
describe('unusual top-level await syntax errors', () => {
const expressions = [
// string
{ expression: '""' },
Expand Down