Skip to content

test: deflake async-hooks/test-improper-order on AIX #58567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gulbaki wants to merge 7 commits into from
Closed

test: deflake async-hooks/test-improper-order on AIX #58567

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5aac532
test: deflake async-hooks/test-improper-order on AIX #58562
bakigul1 Jun 3, 2025
1a80d8a
Update test-improper-order.js
gulbaki Jun 3, 2025
0d35e9b
update test-improper-order.js
gulbaki Jun 3, 2025
0427368
test: improve exit handling in async-hooks/test-improper-order
gulbaki Jun 4, 2025
4a23c0f
test: improve flakiness detection on stack corruption tests
gulbaki Jun 6, 2025
381034a
Apply suggestions from code review
gulbaki Jun 8, 2025
e9f8488
fix lint
gulbaki Jun 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: improve flakiness detection on stack corruption tests
  • Loading branch information
@gulbaki
gulbaki committed Jun 6, 2025
commit 4a23c0f445e5a922c0ea3b267cc4cf03c22c2503
13 changes: 8 additions & 5 deletions test/async-hooks/test-improper-order.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,12 +51,15 @@ if (process.argv[2] === 'child') {
child.stderr.on('data', (d) => { errData = Buffer.concat([ errData, d ]); });
child.stdout.on('data', (d) => { outData = Buffer.concat([ outData, d ]); });

child.once('exit', common.mustCall((code, signal) => {
assert.strictEqual(code, 1);
assert.strictEqual(signal, null);
}));

child.on('close', common.mustCall((code, signal) => {
if ((common.isAIX ||
(common.isLinux && process.arch === 'x64')) &&
signal === 'SIGABRT') {
// XXX: The child process could be aborted due to unknown reasons. Work around it.
Comment thread
gulbaki marked this conversation as resolved.
Resolved
} else {
assert.strictEqual(signal, null);
assert.strictEqual(code, 1);
}
assert.match(outData.toString(), heartbeatMsg,
'did not crash until we reached offending line of code ' +
`(found ${outData})`);
Expand Down