Skip to content

worker: move terminate callback to end-of-life #58528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jasnell wants to merge 3 commits into from
Closed

worker: move terminate callback to end-of-life #58528

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f95328d
worker: move terminate callback to end-of-life
jasnell May 31, 2025
c1bb589
Update doc/api/deprecations.md
jasnell May 31, 2025
ced82c8
Update test/parallel/test-worker-nexttick-terminate.js
jasnell Jun 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update test/parallel/test-worker-nexttick-terminate.js
  • Loading branch information
@jasnell
jasnell authored Jun 1, 2025
commit ced82c88a42db9fb1804ff0c4fcc3482cb31823e
1 change: 0 additions & 1 deletion test/parallel/test-worker-nexttick-terminate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ process.nextTick(() => {
});
`, { eval: true });

// Test deprecation of .terminate() with callback.
w.on('message', common.mustCall(() => {
setTimeout(() => w.terminate().then(common.mustCall()), 1);
}));