Skip to content

benchmark: disambiguate filename and dirname read perf #58056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Apr 29, 2025
Merged

benchmark: disambiguate filename and dirname read perf #58056

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
benchmark: disambiguate filename and dirname read perf
  • Loading branch information
@aduh95
aduh95 committed Apr 27, 2025
commit 229e283d9b3d13362374eeffd596acc398ea92f1
23 changes: 14 additions & 9 deletions benchmark/esm/import-meta.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,32 +1,37 @@
'use strict';

const path = require('path');
const { pathToFileURL, fileURLToPath } = require('url');
const { pathToFileURL } = require('url');
const common = require('../common');
const assert = require('assert');
const bench = common.createBenchmark(main, {
n: [1000],
valuesToRead: [
'dirname-and-filename',
'dirname',
'filename',
],
});

const file = pathToFileURL(
path.resolve(__filename, '../../fixtures/esm-dir-file.mjs'),
);
async function load(array, n) {
const fixtureDir = path.resolve(__filename, '../../fixtures');
const fixtureDirURL = pathToFileURL(fixtureDir);
async function load(array, n, valuesToRead) {
for (let i = 0; i < n; i++) {
array[i] = await import(`${file}?i=${i}`);
array[i] = await import(`${fixtureDirURL}/import-meta-${valuesToRead}.mjs?i=${i}`);
}
return array;
}

function main({ n }) {
function main({ n, valuesToRead }) {
const array = [];
for (let i = 0; i < n; ++i) {
array.push({ dirname: '', filename: '', i: 0 });
}

bench.start();
load(array, n).then((arr) => {
load(array, n, valuesToRead).then((arr) => {
bench.end(n);
assert.strictEqual(arr[n - 1].filename, fileURLToPath(file));
if (valuesToRead.includes('dirname')) assert.strictEqual(arr[n - 1].dirname, fixtureDir);
if (valuesToRead.includes('filename')) assert.strictEqual(arr[n - 1].filename, path.join(fixtureDir, `import-meta-${valuesToRead}.mjs`));
});
}
0 benchmark/fixtures/esm-dir-file.mjs → ...ures/import-meta-dirname-and-filename.mjs
View file
Open in desktop
File renamed without changes.
1 change: 1 addition & 0 deletions benchmark/fixtures/import-meta-dirname.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export const dirname = import.meta.dirname;
1 change: 1 addition & 0 deletions benchmark/fixtures/import-meta-filename.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export const filename = import.meta.filename;