Skip to content

src: use ranges library (C++20) to simplify code #57975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 6 commits into from
Apr 25, 2025
Merged

src: use ranges library (C++20) to simplify code #57975

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9c5e4ab
src: use ranges library (C++20) to simplify code
lemire Apr 22, 2025
1c10b77
breaking long lines
Apr 22, 2025
24b932d
adding missing algorithm header
Apr 22, 2025
2a35e7e
lint
Apr 23, 2025
4d30380
long line
Apr 23, 2025
8289bba
relint
Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
src: use ranges library (C++20) to simplify code
  • Loading branch information
@lemire Daniel Lemire
lemire authored and Daniel Lemire committed Apr 22, 2025
commit 9c5e4ab0380e2ce4573c2bab8b17aa7216d351a1
16 changes: 8 additions & 8 deletions src/node_options-inl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
#if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS

#include <cstdlib>
#include <ranges>
#include "node_options.h"
#include "util.h"

Expand Down Expand Up @@ -394,14 +395,13 @@ void OptionsParser<Options>::Parse(
implied_name.insert(2, "no-");
}
auto implications = implications_.equal_range(implied_name);
for (auto imp = implications.first; imp != implications.second; ++imp) {
if (imp->second.type == kV8Option) {
v8_args->push_back(imp->second.name);
} else {
*imp->second.target_field->template Lookup<bool>(options) =
imp->second.target_value;
}
}
std::ranges::for_each(implications | std::views::values, [&](const auto& value) {
if (value.type == kV8Option) {
v8_args->push_back(value.name);
} else {
*value.target_field->template Lookup<bool>(options) = value.target_value;
}
});
}

if (it == options_.end()) {
Expand Down