Skip to content

build: use clang-cl in coverage-windows workflow #57919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Apr 19, 2025
Merged

build: use clang-cl in coverage-windows workflow #57919

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
build: use clang-cl in coverage-windows workflow 
And do not lose time trying to regenerate the project and rebuild
before running the tests.
  • Loading branch information
@targos
targos committed Apr 17, 2025
commit 106b1a78054e2c0f22da79813c0bbc8cf1439766
4 changes: 2 additions & 2 deletions .github/workflows/coverage-windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,11 @@ jobs:
- name: Environment Information
run: npx envinfo
- name: Build
run: ./vcbuild.bat
run: ./vcbuild.bat clang-cl
# TODO(bcoe): investigate tests that fail with coverage enabled
# on Windows.
- name: Test
run: ./vcbuild.bat test-ci-js; node -e 'process.exit(0)'
run: ./vcbuild.bat noprojgen nobuild test-ci-js; node -e 'process.exit(0)'
env:
NODE_V8_COVERAGE: ./coverage/tmp
- name: Report
Expand Down