Skip to content

lib,tools: rename functions named value #57901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduh95 merged 19 commits into from
Jul 14, 2026
Merged

lib,tools: rename functions named value #57901

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
1b7ce08
lib: rename functions named `value`
LiviaMedeiros Apr 16, 2025
a171be9
tools: added eslint's func-name-matching
louiellan Jul 23, 2025
c314355
test: added eslint's func-name-matching ruletester
louiellan Jul 23, 2025
47c6a2a
test,tools: resolved imported modules for the eslint rule
louiellan Jul 24, 2025
22f5e73
tools: added support for primordials
louiellan Jul 24, 2025
728024e
test: added tests for supporting primordials
louiellan Jul 24, 2025
6eb47be
tools,test: comply with the eslint rules
louiellan Jul 24, 2025
93c6de3
tools: added node-core/func-name-matching rule
louiellan Jul 24, 2025
709e376
doc,lib,test: replaced disable 'func-name-matching' rule comments
louiellan Jul 24, 2025
95d7e11
tools,test: added eslint's license
louiellan Jul 24, 2025
245dd38
test: renamed ruletester file
louiellan Jul 31, 2025
919bf1f
tools: changed to multiple author tags
louiellan Jul 31, 2025
8d08aad
squash: remove empty line
LiviaMedeiros Jul 31, 2025
7c44fd2
squash: remove copyright notice
LiviaMedeiros Aug 1, 2025
bbb111d
squash: move checks to selectors
LiviaMedeiros Aug 1, 2025
55163d9
squash: Update tools/eslint-rules/func-name-matching.js
LiviaMedeiros May 16, 2026
ea7c4e5
squash: rename yet another `function value`
LiviaMedeiros May 25, 2026
7699aa2
squash: remove unused linter directive
LiviaMedeiros May 25, 2026
c025626
squash: set new linter directive
LiviaMedeiros May 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
squash: remove unused linter directive
  • Loading branch information
@LiviaMedeiros
LiviaMedeiros committed May 25, 2026
commit 7699aa20f53f0a1b7e34df0e29949d8acdd450f2
1 change: 0 additions & 1 deletion lib/repl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -687,8 +687,7 @@
// The function names are needed for stack trace filtering - they must not
// be anonymous, but we can't use 'eval' as a name since it's reserved.
const originalEval = eval_;
// eslint-disable-next-line func-name-matching
self.eval = function REPLEval(code, context, file, cb) {

Check failure on line 690 in lib/repl.js

View workflow job for this annotation

GitHub Actions / lint-js-and-md 

Function name `REPLEval` should match property name `eval`
replContext.run({ replServer: self }, function REPLEvalInContext() {
originalEval(code, context, file, cb);
});
Expand Down
Loading