Skip to content

worker: add worker.getHeapStatistics() #57888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 19 commits into from
Apr 17, 2025
Merged

worker: add worker.getHeapStatistics() #57888

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
94ec4e6
worker: add worker.getHeapStatistics()
mcollina Apr 15, 2025
852078c
fixup
mcollina Apr 15, 2025
c73d1b6
fixup
mcollina Apr 15, 2025
599fb2c
fixup
mcollina Apr 15, 2025
d219327
fixup
mcollina Apr 15, 2025
8b1266a
fixup
mcollina Apr 15, 2025
09741f2
macros
mcollina Apr 15, 2025
76d4027
object initialization
mcollina Apr 15, 2025
47bd934
refactor to use an interrupt
mcollina Apr 15, 2025
ea24ef4
fixup
mcollina Apr 15, 2025
821744f
fixup
mcollina Apr 15, 2025
8236424
linting
mcollina Apr 15, 2025
ab5f978
fixup
mcollina Apr 15, 2025
a3e2066
fixup
mcollina Apr 15, 2025
99c6b80
fixup
mcollina Apr 15, 2025
c7ab253
Update src/node_worker.cc
mcollina Apr 16, 2025
e40a220
review feedbacks
mcollina Apr 16, 2025
645d972
fixup
mcollina Apr 16, 2025
df57fa3
fixup
mcollina Apr 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup 
Signed-off-by: Matteo Collina <hello@matteocollina.com>
  • Loading branch information
@mcollina
mcollina committed Apr 15, 2025
commit 599fb2c7ee7a5c7751b75016e8d0cad88864fec3
29 changes: 14 additions & 15 deletions src/node_worker.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -830,50 +830,50 @@ void Worker::GetHeapStatistics(const FunctionCallbackInfo<Value>& args) {

stats->Set(currentContext,
String::NewFromUtf8(isolate, "total_heap_size").ToLocalChecked(),
Number::New(isolate, heap_stats.total_heap_size()));
Number::New(isolate, heap_stats.total_heap_size())).Check();
stats->Set(currentContext,
String::NewFromUtf8(isolate, "total_heap_size_executable")
.ToLocalChecked(),
Number::New(isolate, heap_stats.total_heap_size_executable()));
Number::New(isolate, heap_stats.total_heap_size_executable())).Check();
stats->Set(currentContext,
String::NewFromUtf8(isolate, "total_physical_size").ToLocalChecked(),
Number::New(isolate, heap_stats.total_physical_size()));
Number::New(isolate, heap_stats.total_physical_size())).Check();
stats->Set(currentContext,
String::NewFromUtf8(isolate, "total_available_size").ToLocalChecked(),
Number::New(isolate, heap_stats.total_available_size()));
Number::New(isolate, heap_stats.total_available_size())).Check();
stats->Set(currentContext,
String::NewFromUtf8(isolate, "used_heap_size").ToLocalChecked(),
Number::New(isolate, heap_stats.used_heap_size()));
Number::New(isolate, heap_stats.used_heap_size())).Check();
stats->Set(currentContext,
String::NewFromUtf8(isolate, "heap_size_limit").ToLocalChecked(),
Number::New(isolate, heap_stats.heap_size_limit()));
Number::New(isolate, heap_stats.heap_size_limit())).Check();
stats->Set(currentContext,
String::NewFromUtf8(isolate, "malloced_memory").ToLocalChecked(),
Number::New(isolate, heap_stats.malloced_memory()));
Number::New(isolate, heap_stats.malloced_memory())).Check();
stats->Set(currentContext,
String::NewFromUtf8(isolate, "peak_malloced_memory").ToLocalChecked(),
Number::New(isolate, heap_stats.peak_malloced_memory()));
Number::New(isolate, heap_stats.peak_malloced_memory())).Check();
stats->Set(currentContext,
String::NewFromUtf8(isolate, "does_zap_garbage").ToLocalChecked(),
Boolean::New(isolate, heap_stats.does_zap_garbage()));
Boolean::New(isolate, heap_stats.does_zap_garbage())).Check();
stats->Set(currentContext,
String::NewFromUtf8(isolate, "number_of_native_contexts")
.ToLocalChecked(),
Number::New(isolate, heap_stats.number_of_native_contexts()));
Number::New(isolate, heap_stats.number_of_native_contexts())).Check();
stats->Set(currentContext,
String::NewFromUtf8(isolate, "number_of_detached_contexts")
.ToLocalChecked(),
Number::New(isolate, heap_stats.number_of_detached_contexts()));
Number::New(isolate, heap_stats.number_of_detached_contexts())).Check();
stats->Set(currentContext,
String::NewFromUtf8(isolate, "total_global_handles_size")
.ToLocalChecked(),
Number::New(isolate, heap_stats.total_global_handles_size()));
Number::New(isolate, heap_stats.total_global_handles_size())).Check();
stats->Set(currentContext,
String::NewFromUtf8(isolate, "used_global_handles_size").ToLocalChecked(),
Number::New(isolate, heap_stats.used_global_handles_size()));
Number::New(isolate, heap_stats.used_global_handles_size())).Check();
stats->Set(currentContext,
String::NewFromUtf8(isolate, "external_memory").ToLocalChecked(),
Number::New(isolate, heap_stats.external_memory()));
Number::New(isolate, heap_stats.external_memory())).Check();

args.GetReturnValue().Set(stats);
}
Expand Down Expand Up @@ -1060,7 +1060,6 @@ void CreateWorkerPerIsolateProperties(IsolateData* isolate_data,
SetProtoMethod(isolate, w, "loopStartTime", Worker::LoopStartTime);
SetProtoMethod(isolate, w, "getHeapStatistics", Worker::GetHeapStatistics);


SetConstructorFunction(isolate, target, "Worker", w);
}

Expand Down