Skip to content

http2: fix graceful session close #57808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 7 commits into from
Apr 19, 2025
Merged

http2: fix graceful session close #57808

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
20ba444
http2: fix graceful session close
pandeykushagra51 Apr 9, 2025
0f36493
test: fixed request-response handling
pandeykushagra51 Apr 9, 2025
f26c10f
test: fix lint errors
pandeykushagra51 Apr 11, 2025
bcd98a1
http2: Reduces overhead during HTTP/2 session closure by minimizing c…
pandeykushagra51 Apr 11, 2025
87e9b8b
http2: fixed cpp lint error
pandeykushagra51 Apr 11, 2025
8f45d88
test: fixed incorrect http2 stream close test failure
pandeykushagra51 Apr 12, 2025
d54f12c
resolved PR comment: fixed names and added description
pandeykushagra51 Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
http2: fixed cpp lint error
  • Loading branch information
@pandeykushagra51
pandeykushagra51 committed Apr 11, 2025
commit 87e9b8bf1e87da0f890f0e18468dfbabbf74640a
5 changes: 1 addition & 4 deletions src/node_http2.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3520,10 +3520,7 @@ void Initialize(Local<Object> target,
Http2Session::RefreshSettings<nghttp2_session_get_remote_settings,
false>);
SetProtoMethod(
isolate,
session,
"setGracefulClose",
Http2Session::SetGracefulClose);
isolate, session, "setGracefulClose", Http2Session::SetGracefulClose);
SetConstructorFunction(context, target, "Http2Session", session);

Local<Object> constants = Object::New(isolate);
Expand Down
4 changes: 3 additions & 1 deletion src/node_http2.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -788,7 +788,9 @@ class Http2Session : public AsyncWrap,

Statistics statistics_ = {};

bool IsGracefulCloseInitiated() const { return graceful_close_initiated_; }
bool IsGracefulCloseInitiated() const {
return graceful_close_initiated_;
}
void SetGracefulCloseInitiated(bool value) {
graceful_close_initiated_ = value;
}
Expand Down