Skip to content

test_runner: improve --test-timeout to be per test #57672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 10 commits into from
Apr 9, 2025
Merged

test_runner: improve --test-timeout to be per test #57672

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c1c48ec
test_runner: improve --test-timeout to be per test
jakecastelli Mar 29, 2025
c1f5562
fixup! change timeout to 20ms and format the file
jakecastelli Mar 29, 2025
07863c5
fixup! reduce test timeout and improve test desc
jakecastelli Mar 29, 2025
180116b
fixup! hoist timeoutPerTest out of if
jakecastelli Mar 31, 2025
af2201e
address PR comments
jakecastelli Apr 4, 2025
6559293
remove deuplicated if checks and move this.timeout into FileTest and …
jakecastelli Apr 4, 2025
24a1936
fixup! fix tests
jakecastelli Apr 8, 2025
04f280b
fixup! address more comments
jakecastelli Apr 8, 2025
ab0e86a
fixup! incorrect logic for cli timeout to take precedent
jakecastelli Apr 9, 2025
44c7757
fixup! linting error
jakecastelli Apr 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! change timeout to 20ms and format the file
  • Loading branch information
@jakecastelli
jakecastelli committed Mar 29, 2025
commit c1f556200038c0834061d5a1433886163d8bcbe3
8 changes: 4 additions & 4 deletions test/fixtures/test-runner/output/test-timeout-flag.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
// Flags: --test-timeout=500
// Flags: --test-timeout=20
'use strict';
const { describe, test } = require('node:test');
const { setTimeout } = require('node:timers/promises');

describe('--test-timeout is set to 500ms', () => {
test('test 1 must fail due to testTimeoutFailure with error test timed out after 500ms', async () => {
describe('--test-timeout is set to 20ms', () => {
Comment thread
jakecastelli marked this conversation as resolved.
Resolved
test('test 1 must fail due to testTimeoutFailure with error test timed out after 20ms', async () => {
await setTimeout(1000);
})
test('test 2 must fail due to testTimeoutFailure with error test timed out after 600ms', { timeout: 600 }, async () => {
Expand All @@ -13,4 +13,4 @@ describe('--test-timeout is set to 500ms', () => {
test('test 3 must pass', async () => {
await setTimeout(10);
})
});
});
10 changes: 5 additions & 5 deletions test/fixtures/test-runner/output/test-timeout-flag.snapshot
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
TAP version 13
# Subtest: --test-timeout is set to 500ms
# Subtest: test 1 must fail due to testTimeoutFailure with error test timed out after 500ms
not ok 1 - test 1 must fail due to testTimeoutFailure with error test timed out after 500ms
# Subtest: --test-timeout is set to 20ms
# Subtest: test 1 must fail due to testTimeoutFailure with error test timed out after 20ms
not ok 1 - test 1 must fail due to testTimeoutFailure with error test timed out after 20ms
---
duration_ms: *
type: 'test'
location: '/test/fixtures/test-runner/output/test-timeout-flag.js:(LINE):3'
failureType: 'testTimeoutFailure'
error: 'test timed out after 500ms'
error: 'test timed out after 20ms'
code: 'ERR_TEST_FAILURE'
stack: |-
async Promise.all (index 0)
Expand All @@ -29,7 +29,7 @@ TAP version 13
type: 'test'
...
1..3
not ok 1 - --test-timeout is set to 500ms
not ok 1 - --test-timeout is set to 20ms
---
duration_ms: *
type: 'suite'
Expand Down