Skip to content

esm: syncify default path of ModuleLoader.load #57419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 11 commits into from
Jun 11, 2025
Merged

esm: syncify default path of ModuleLoader.load #57419

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
fc540c2
esm: syncify default path of `ModuleLoader.load`
JakobJingleheimer Mar 9, 2025
fffcc31
!fixup: don't force `ModuleLoader.load` to be async (can via hooks)
JakobJingleheimer Mar 9, 2025
cdeb423
!fixup: remove obsolete `getSource` in favour of `getSourceSync`
JakobJingleheimer Mar 12, 2025
d78eb9f
!fixup: account for `node:internal` in `isMain` check
JakobJingleheimer Mar 17, 2025
8630ad7
Revert "!fixup: account for `node:internal` in `isMain` check"
JakobJingleheimer Apr 5, 2025
ce7fd9c
Reapply "!fixup: account for `node:internal` in `isMain` check"
JakobJingleheimer Apr 8, 2025
257f480
fixup!: add todo & note about mysterious fix/failure
JakobJingleheimer Apr 8, 2025
11d543b
fixup!: move isInternal check to specific vm resolve path
JakobJingleheimer Apr 9, 2025
f6a8cd0
fixup!: remove `referrerName === 'node:internal/process/task_queues'`
JakobJingleheimer Apr 22, 2025
6f910e4
module: exclude `node:` prefixed referrer as "parsable url"
JakobJingleheimer Apr 22, 2025
a31d408
revert change to helper (detecting `node:` prefix)
JakobJingleheimer May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
revert change to helper (detecting node: prefix)
  • Loading branch information
@JakobJingleheimer
JakobJingleheimer committed Jun 11, 2025
commit a31d4084563d61cd0cf76535c1fc4dd5c0ff2198
9 changes: 2 additions & 7 deletions lib/internal/modules/helpers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,13 +263,8 @@ function normalizeReferrerURL(referrerName) {
return pathToFileURL(referrerName).href;
}

if (
StringPrototypeStartsWith(referrerName, 'file://') ||
(
!StringPrototypeStartsWith(referrerName, 'node:') &&
URLCanParse(referrerName)
)
) {
if (StringPrototypeStartsWith(referrerName, 'file://') ||
URLCanParse(referrerName)) {
return referrerName;
}

Expand Down