Skip to content

src: port initializeImportMeta to native #57286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduh95 merged 12 commits into from
Apr 29, 2025
Merged

src: port initializeImportMeta to native #57286

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
a1edf9c
src: port `initializeImportMeta` to native
aduh95 Feb 19, 2025
a3899b0
Apply suggestions from code review
aduh95 Mar 10, 2025
7212254
add TODO
aduh95 Mar 10, 2025
537613b
only port path helpers to C++
aduh95 Apr 25, 2025
e7c7320
add private property to avoid calling ada twice
aduh95 Apr 25, 2025
24cc9a6
lint
aduh95 Apr 25, 2025
e2beab2
fixup! lint
aduh95 Apr 25, 2025
8f5285b
fixup! lint
aduh95 Apr 25, 2025
3fa0db0
benchmark: disambiguate `filename` and `dirname` read perf
aduh95 Apr 25, 2025
79ec952
fixup! benchmark: disambiguate `filename` and `dirname` read perf
aduh95 Apr 25, 2025
077bde3
Revert "add private property to avoid calling ada twice"
aduh95 Apr 25, 2025
6b10319
fixup! Revert "add private property to avoid calling ada twice"
aduh95 Apr 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "add private property to avoid calling ada twice"
  • Loading branch information
@aduh95
aduh95 committed Apr 25, 2025
commit 077bde31948e491262f6b1ebcf184c128e7a8fc3
1 change: 0 additions & 1 deletion src/env_properties.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
V(module_circular_visited_private_symbol, "node:module_circular_visited") \
V(module_export_private_symbol, "node:module_export") \
V(module_parent_private_symbol, "node:module_parent") \
V(module_import_meta_path, "node:module_import_meta_path") \
V(napi_type_tag, "node:napi:type_tag") \
V(napi_wrapper, "node:napi:wrapper") \
V(untransferable_object_private_symbol, "node:untransferableObject") \
Expand Down
24 changes: 1 addition & 23 deletions src/node_modules.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -629,25 +629,6 @@ static void PathHelpersLazyGetter(Local<v8::Name> name,
CHECK(index != std::string_view::npos); \
ret_view.remove_suffix(ret_view.size() - index)

Local<Value> ret;
if (receiver->HasPrivate(context, env->module_import_meta_path())
.FromMaybe(false)) {
auto maybe_value =
receiver->GetPrivate(context, env->module_import_meta_path());
if (!maybe_value.ToLocal(&ret)) return;

if (plain_name == "dirname") {
node::Utf8Value utf8name(isolate, ret.As<String>());
auto ret_view = utf8name.ToStringView();
dirname(ret_view);
if (!ToV8Value(context, ret_view, isolate).ToLocal(&ret)) {
return;
}
}
info.GetReturnValue().Set(ret);
receiver->DeletePrivate(context, env->module_import_meta_path());
return;
}

node::Utf8Value url(isolate, info.Data());
auto file_url = ada::parse(url.ToStringView());
Expand All @@ -656,13 +637,10 @@ static void PathHelpersLazyGetter(Local<v8::Name> name,
CHECK(file_path.has_value());
std::string_view ret_view = file_path.value();

if (!ToV8Value(context, ret_view, isolate).ToLocal(&ret)) {
return;
}
receiver->SetPrivate(context, env->module_import_meta_path(), ret);
if (plain_name == "dirname") {
dirname(ret_view);
}
Local<Value> ret;
if (!ToV8Value(context, ret_view, isolate).ToLocal(&ret)) {
return;
}
Expand Down