Skip to content

crypto: add support for intermediate certs in --use-system-ca #57164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 11 commits into from
Mar 5, 2025
Merged

crypto: add support for intermediate certs in --use-system-ca #57164

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
0329748
crypto: add support for intermediate certs in --use-system-ca
timja Feb 21, 2025
e6d4cc0
Add intermediate cert test
timja Feb 21, 2025
0bcaa01
Fix lint
timja Feb 22, 2025
c3b8c05
Add linux instructions
timja Feb 22, 2025
6af913a
Ensure trust fails with non trusted root and trusted intermediate
timja Feb 27, 2025
c04ffa3
Tweaks after running on Windows
timja Feb 27, 2025
f7a2291
Fmt
timja Feb 27, 2025
62c35dd
Fmt
timja Feb 27, 2025
46b5e4c
Move tests to separate folder
timja Mar 3, 2025
a24114e
Remove unneeded file
timja Mar 3, 2025
583c4ce
Fix lint
timja Mar 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix lint
  • Loading branch information
@timja
timja committed Feb 22, 2025
commit 0bcaa01613968bd494d20a4c73c027becc4d0bf5
12 changes: 6 additions & 6 deletions test/parallel/test-native-certs.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ const handleRequest = (req, res) => {
};

describe('use-system-ca', function() {

async function setupServer(key, cert) {
Comment thread
timja marked this conversation as resolved.
Outdated
const theServer = https.createServer({
key: fixtures.readKey(key),
Expand All @@ -75,7 +75,7 @@ describe('use-system-ca', function() {
theServer.listen(0);
await once(theServer, 'listening');

return theServer
return theServer;
}

describe('signed with a root certificate', () => {
Expand All @@ -84,11 +84,11 @@ describe('use-system-ca', function() {
beforeEach(async function() {
server = await setupServer('agent8-key.pem', 'agent8-cert.pem');
});

it('can connect successfully', async function() {
await fetch(`https://localhost:${server.address().port}/hello-world`);
});

afterEach(async function() {
server?.close();
});
Expand All @@ -100,11 +100,11 @@ describe('use-system-ca', function() {
beforeEach(async function() {
server = await setupServer('leaf-from-intermediate-key.pem', 'leaf-from-intermediate-cert.pem');
});

it('can connect successfully', async function() {
await fetch(`https://localhost:${server.address().port}/hello-world`);
});

afterEach(async function() {
server?.close();
});
Expand Down