Skip to content

Enable ccache on Windows v2 #56847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 11 commits into from
Feb 9, 2025
Merged

Enable ccache on Windows v2 #56847

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
e3a005f
build,win: enable ccache
StefanStojanovic Dec 20, 2024
595ffe5
doc,win: add ccache support
StefanStojanovic Jan 21, 2025
0dee0d9
deps: change V8 generated .h files for ccache
StefanStojanovic Jan 21, 2025
11446b1
fix: resolve PR comments
StefanStojanovic Jan 31, 2025
cf0a037
Update configure.py
StefanStojanovic Feb 4, 2025
8acf94c
Update configure.py
StefanStojanovic Feb 4, 2025
2f711ac
Update configure.py
StefanStojanovic Feb 4, 2025
be40ada
Update configure.py
StefanStojanovic Feb 4, 2025
7d8baa4
Update tools/v8_gypfiles/v8.gyp
StefanStojanovic Feb 4, 2025
8382b15
Update common.gypi
StefanStojanovic Feb 4, 2025
2e834a1
Update vcbuild.bat
StefanStojanovic Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: resolve PR comments 
Add cp command in building docs
Remove CCACHE_USED macro
Disable PCH when using Clang and ccache
  • Loading branch information
@StefanStojanovic
StefanStojanovic committed Feb 4, 2025
commit 11446b1d76677e9136885387fa87671060b48533
6 changes: 5 additions & 1 deletion BUILDING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -579,7 +579,11 @@ Tips: follow <https://github.com/ccache/ccache/wiki/MS-Visual-Studio>, and you
should notice that obj file will be bigger the normal one.

First, install ccache, assume ccache install to c:\ccache, copy
c:\ccache\ccache.exe to c:\ccache\cl.exe
c:\ccache\ccache.exe to c:\ccache\cl.exe with this command

```powershell
cp c:\ccache\ccache.exe c:\ccache\cl.exe
```

When building Node.js provide a path to your ccache via the option

Expand Down
3 changes: 0 additions & 3 deletions common.gypi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,9 +484,6 @@
'NOMINMAX',
],
}],
['ccache_used == 1', {
'defines': ['CCACHE_USED',],
}],
[ 'OS in "linux freebsd openbsd solaris aix os400"', {
'cflags': [ '-pthread' ],
'ldflags': [ '-pthread' ],
Expand Down
8 changes: 0 additions & 8 deletions deps/v8/src/builtins/generate-bytecodes-builtins-list.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,14 +41,6 @@ void WriteBytecode(std::ofstream& out, Bytecode bytecode,
void WriteHeader(const char* header_filename) {
std::ofstream out(header_filename);

#ifdef CCACHE_USED
// Write a cache invalidator to ensure that ccache does not cache this file.
out << "#ifndef CACHE_INVALIDATOR\n"
<< "#define CACHE_INVALIDATOR\n"
<< "inline const char* cache_invalidator = __TIME__;\n"
<< "#endif\n\n";
#endif

out << "// Automatically generated from interpreter/bytecodes.h\n"
<< "// The following list macro is used to populate the builtins list\n"
<< "// with the bytecode handlers\n\n"
Expand Down
2 changes: 1 addition & 1 deletion tools/v8_gypfiles/v8.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
'type': 'none',
'toolsets': ['host', 'target'],
'conditions': [
['OS=="win"', {
['OS == "win" and (clang != 1 or ccache_used != 1)', {
Comment thread
StefanStojanovic marked this conversation as resolved.
Resolved
'direct_dependent_settings': {
'msvs_precompiled_header': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.h',
'msvs_precompiled_source': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.cc',
Expand Down