Skip to content

quic: fixup errant LocalVector usage #56564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jasnell wants to merge 2 commits into from
Closed

quic: fixup errant LocalVector usage #56564

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e89b2bc
quic: fixup errant LocalVector usage
jasnell Jan 11, 2025
f1b3f75
Update src/quic/session.cc
jasnell Jan 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update src/quic/session.cc 
Co-authored-by: Yagiz Nizipli <yagiz@nizipli.com>
  • Loading branch information
@jasnell @anonrig
jasnell and anonrig authored Jan 12, 2025
commit f1b3f7595a101a232684bbb13aaa0d19f503d9e6
2 changes: 1 addition & 1 deletion src/quic/session.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2728,7 +2728,7 @@ void Session::EmitVersionNegotiation(const ngtcp2_pkt_hd& hd,

LocalVector<Value> versions(env()->isolate(), nsv);
for (size_t n = 0; n < nsv; n++) {
versions[0] = Integer::NewFromUnsigned(env()->isolate(), sv[n]);
versions[n] = Integer::NewFromUnsigned(env()->isolate(), sv[n]);
}

// supported are the versions we acutually support expressed as a range.
Expand Down