Skip to content

src: move more crypto impl detail to ncrypto dep #56444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jasnell wants to merge 12 commits into from
Closed

src: move more crypto impl detail to ncrypto dep #56444

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
fe4f104
src: move more crypto impl detail to ncrypto dep
jasnell Dec 31, 2024
524e188
src: remove obsolete LogSecret function
jasnell Dec 31, 2024
24d2aac
src: move StackOfX509 decl to ncrypto
jasnell Dec 31, 2024
4f9eba8
src: colocate GetSSLOCSPResponse with callsite
jasnell Dec 31, 2024
571a6fe
src: move x509 error code and reason to ncrypto
jasnell Dec 31, 2024
1093eec
src: simplify X509Pointer/X509View pointer derefs a bit
jasnell Dec 31, 2024
03fa354
src: move prime gen and checks to ncrypto
jasnell Jan 1, 2025
0ce9473
src: move BN_* methods into ncrypto
jasnell Jan 1, 2025
d8efc4c
src: move SSLPointer impl to ncrypto
jasnell Jan 2, 2025
f2756bd
src: move SSLCtxPointer impl to ncrypto
jasnell Jan 2, 2025
e6b27ca
src: move EVP_CIPHER methods to ncrypto
jasnell Jan 2, 2025
4f43fd0
src: move CipherCtx methods to ncrypto
jasnell Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
src: remove obsolete LogSecret function 
Nothing was using it.
  • Loading branch information
@jasnell
jasnell committed Jan 2, 2025
commit 524e18805d158a1c68eaf120246a7dd80b406362
23 changes: 0 additions & 23 deletions src/crypto/crypto_common.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,29 +41,6 @@ using v8::Undefined;
using v8::Value;

namespace crypto {
void LogSecret(
const SSLPointer& ssl,
const char* name,
const unsigned char* secret,
size_t secretlen) {
auto keylog_cb = SSL_CTX_get_keylog_callback(SSL_get_SSL_CTX(ssl.get()));
// All supported versions of TLS/SSL fix the client random to the same size.
constexpr size_t kTlsClientRandomSize = SSL3_RANDOM_SIZE;
unsigned char crandom[kTlsClientRandomSize];

if (keylog_cb == nullptr ||
SSL_get_client_random(ssl.get(), crandom, kTlsClientRandomSize) !=
kTlsClientRandomSize) {
return;
}

std::string line = name;
line += " " + nbytes::HexEncode(reinterpret_cast<const char*>(crandom),
kTlsClientRandomSize);
line +=
" " + nbytes::HexEncode(reinterpret_cast<const char*>(secret), secretlen);
keylog_cb(ssl.get(), line.c_str());
}

MaybeLocal<Value> GetSSLOCSPResponse(
Environment* env,
Expand Down
6 changes: 0 additions & 6 deletions src/crypto/crypto_common.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,6 @@ struct StackOfX509Deleter {
};
using StackOfX509 = std::unique_ptr<STACK_OF(X509), StackOfX509Deleter>;

void LogSecret(
const SSLPointer& ssl,
const char* name,
const unsigned char* secret,
size_t secretlen);

v8::MaybeLocal<v8::Value> GetSSLOCSPResponse(
Environment* env,
SSL* ssl,
Expand Down