Skip to content

module: fixing url change in load sync hook chain #56402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
awto wants to merge 8 commits into from
Closed

module: fixing url change in load sync hook chain #56402

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
084e18a
module: fixing url change in load sync hook chain
awto Dec 29, 2024
5451b58
more readable test
awto Dec 30, 2024
15872d6
Update test/module-hooks/test-module-hooks-load-url-change.js
awto Jan 2, 2025
d90bd6a
Update test/module-hooks/test-module-hooks-load-url-change.js
awto Jan 6, 2025
a239975
url rewriting for import
awto Jan 7, 2025
09003dd
a test of import and a fix for windows
awto Jan 8, 2025
cd26b45
lint fixes
awto Jan 9, 2025
f60c6df
linter fix
awto Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
lint fixes
  • Loading branch information
@awto
awto committed Jan 16, 2025
commit cd26b450f5ae40b5a84cc48498271e4afcf24d65
9 changes: 1 addition & 8 deletions test/module-hooks/test-module-hooks-load-url-change-import.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,7 @@
'use strict';

import { mustCall } from '../common/index.mjs';
import assert from 'node:assert';
import { registerHooks } from 'node:module';
import { fileURL } from '../common/fixtures.mjs';
import { pathToFileURL } from "node:url";
import { sep as pathSep } from "node:path";

// This tests shows the url parameter in `load` can be changed in the `nextLoad` call
// It changes `foo` package name into `redirected-fs` and then loads `redirected-fs`
Expand All @@ -20,10 +16,7 @@ const hook = registerHooks({
},
load: mustCall(function load(url, context, nextLoad) {
assert.strictEqual(url, 'foo://bar');
return nextLoad(
fileURL('module-hooks', `redirected-fs.js`).href,
context
);
return nextLoad(fileURL('module-hooks', 'redirected-fs.js').href, context);
}),
});

Expand Down
8 changes: 4 additions & 4 deletions test/module-hooks/test-module-hooks-load-url-change-require.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,15 @@ const hook = registerHooks({
resolve(specifier, context, nextResolve) {
assert.strictEqual(specifier, 'foo');
return {
url: "foo://bar",
url: 'foo://bar',
shortCircuit: true,
};
},
load: common.mustCall(function load(url, context, nextLoad) {
assert.strictEqual(url, "foo://bar",);
assert.strictEqual(url, 'foo://bar');
return nextLoad(
fixtures.fileURL('module-hooks', `redirected-fs.js`).href,
context,
fixtures.fileURL('module-hooks', 'redirected-fs.js').href,
context
);
}),
});
Expand Down