Skip to content

tools: validate commit list as part of lint-release-commit #56291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 11 commits into from
Jan 9, 2025
Merged

tools: validate commit list as part of lint-release-commit #56291

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
75be282
tools: validate commit list as part of `lint-release-commit`
aduh95 Dec 17, 2024
e3b2220
fixup! tools: validate commit list as part of `lint-release-commit`
aduh95 Dec 17, 2024
60a0bce
Update .github/workflows/lint-release-proposal.yml
aduh95 Dec 17, 2024
5e54f8f
fixup! tools: validate commit list as part of `lint-release-commit`
aduh95 Dec 17, 2024
686d5cb
minor fixes and improvements
aduh95 Dec 18, 2024
d69f027
move JS to a separate file
aduh95 Dec 18, 2024
eae03e3
fix for revert commits
aduh95 Dec 18, 2024
e8bb005
add validation for dont-land labels
aduh95 Dec 19, 2024
6022db5
fixup! add validation for dont-land labels
aduh95 Dec 19, 2024
2ec8cbd
use a format of input somewhat compatible with `git log`
aduh95 Dec 19, 2024
ba114e9
add error message to help with debugging
aduh95 Dec 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix for revert commits
  • Loading branch information
@aduh95
aduh95 committed Dec 18, 2024
commit eae03e36cc79a4a10eb744177c2278b4d643ccfb
5 changes: 4 additions & 1 deletion tools/actions/lint-release-proposal-commit-list.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,10 @@ for await (const line of stdinLineByLine) {
continue;
}

assert(commitList.includes('\n' + line), `Missing "${line}" in commit list`);
// Revert commit have a special treatment.
const fixedLine = line.replace(' - **Revert \"', ' - _**Revert**_ "**');

assert(commitList.includes('\n' + fixedLine), `Missing "${fixedLine}" in commit list`);
expectedNumberOfCommitsLeft--;
}
assert.strictEqual(expectedNumberOfCommitsLeft, 0, 'Release commit is not the last commit in the proposal');