Skip to content

worker: fix crash when a worker joins after exit #56191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Dec 11, 2024
Merged

worker: fix crash when a worker joins after exit #56191

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
worker: fix crash when a worker joins after exit 
If a worker has not already joined before running to completion
it will join in a SetImmediateThreadsafe which could occur after
the worker has already ended by other means. Mutating a JS object
at that point would fail because the isolate is already disposed.
  • Loading branch information
@Qard
Qard committed Dec 9, 2024
commit 6d4a4d53fc5f20c29ced30a474cc940425a7f136
3 changes: 3 additions & 0 deletions src/node_worker.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,6 +449,9 @@ void Worker::JoinThread() {

env()->remove_sub_worker_context(this);

// Join may happen after the worker exits and disposes the isolate
if (!env()->can_call_into_js()) return;

{
HandleScope handle_scope(env()->isolate());
Context::Scope context_scope(env()->context());
Expand Down