Skip to content

lib: clean up persisted signals when they are settled #56001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduh95 merged 5 commits into from
Dec 8, 2024
Merged

lib: clean up persisted signals when they are settled #56001

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
86f7b92
lib: settle signals when controller's signal is GCed
geeksilva97 Nov 26, 2024
643efe1
test: test clean up settled signals
geeksilva97 Nov 26, 2024
e152212
fixup: remove unneeded comments
geeksilva97 Nov 26, 2024
9d3074e
chore: remove unused statements
geeksilva97 Nov 26, 2024
c11785e
lib: handle composed signals finalization
geeksilva97 Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup: remove unneeded comments
  • Loading branch information
@geeksilva97
geeksilva97 committed Nov 26, 2024
commit e1522128218b0995b15b3169484715a4d12d636e
4 changes: 1 addition & 3 deletions lib/internal/abort_controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,9 +276,7 @@ class AbortSignal extends EventTarget {
resultSignal[kSourceSignals].add(signalWeakRef);
signal[kDependantSignals].add(resultSignalWeakRef);
dependantSignalsCleanupRegistry.register(resultSignal, signalWeakRef);
// when the source signal - coming from the controller - is gced, we need to remove it from the dependant
// signals of the composite signal
finalizer.register(signal, { sourceSignalRef: signalWeakRef, composedSignalRef: resultSignalWeakRef});
finalizer.register(signal, { sourceSignalRef: signalWeakRef, composedSignalRef: resultSignalWeakRef });
Comment thread
geeksilva97 marked this conversation as resolved.
Resolved
} else if (!signal[kSourceSignals]) {
continue;
} else {
Expand Down