Skip to content

module: improve error message for top-level await in CommonJS #55874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 14 commits into from
Jun 24, 2025
Merged

module: improve error message for top-level await in CommonJS #55874

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
77c3d19
module: update tests for combined ambiguous module syntax error
mertcanaltin May 31, 2025
10e5620
lint
mertcanaltin May 31, 2025
b0d51ac
revert regex edit
mertcanaltin Jun 2, 2025
ab7ee6e
repair error message
mertcanaltin Jun 2, 2025
5725135
refactored ERR_AMBIGUOUS_MODULE_SYNTAX error
mertcanaltin Jun 3, 2025
f9bd373
repair hasTopLevelAwait & tests
mertcanaltin Jun 3, 2025
aab10e5
lint
mertcanaltin Jun 3, 2025
d756f7f
revert old change
mertcanaltin Jun 3, 2025
a2a9302
test repair
mertcanaltin Jun 3, 2025
53b03da
repair e.message
mertcanaltin Jun 3, 2025
32247d1
register HasTopLevelAwait method in cpp api
mertcanaltin Jun 3, 2025
811e9c5
lint
mertcanaltin Jun 3, 2025
0f126d0
update error message expectation for module syntax
mertcanaltin Jun 24, 2025
ad40103
lint
mertcanaltin Jun 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
lint
  • Loading branch information
@mertcanaltin
mertcanaltin committed Jun 24, 2025
commit ad40103a0ee10821c40686e48469b4ab389b8325
10 changes: 5 additions & 5 deletions lib/internal/modules/esm/module_job.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,11 +76,11 @@ const explainCommonJSGlobalLikeNotDefinedError = (e, url, hasTopLevelAwait) => {
if (e?.name === 'ReferenceError' &&
isCommonJSGlobalLikeNotDefinedError(e.message)) {

if (hasTopLevelAwait) {
e.message = `Cannot determine intended module format because both require() and top-level await are present. If the code is intended to be CommonJS, wrap await in an async function. If the code is intended to be an ES module, replace require() with import.`;
e.code = 'ERR_AMBIGUOUS_MODULE_SYNTAX';
return;
}
if (hasTopLevelAwait) {
e.message = `Cannot determine intended module format because both require() and top-level await are present. If the code is intended to be CommonJS, wrap await in an async function. If the code is intended to be an ES module, replace require() with import.`;
e.code = 'ERR_AMBIGUOUS_MODULE_SYNTAX';
return;
}

e.message += ' in ES module scope';

Expand Down