Skip to content

module: avoid throwing when findPackageJSON is called on nonexistent #55822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JakobJingleheimer wants to merge 1 commit into from
Closed

module: avoid throwing when findPackageJSON is called on nonexistent #55822

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
module: avoid throwing when findPackageJSON is called on nonexistent
  • Loading branch information
@JakobJingleheimer
JakobJingleheimer committed Nov 11, 2024
commit c02aebc11f354e71362609aa77470730171fc795
3 changes: 3 additions & 0 deletions lib/internal/modules/package_json_reader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,6 +296,7 @@ function findPackageJSON(specifier, base = 'data:') {
return packageJSONPath;
}

/** @type {string} */
let resolvedTarget;
cascadedLoader ??= require('internal/modules/esm/loader').getOrInitializeCascadedLoader();

Expand All @@ -309,6 +310,8 @@ function findPackageJSON(specifier, base = 'data:') {
}
}

if (resolvedTarget == null) { return; }

const pkg = getNearestParentPackageJSON(fileURLToPath(resolvedTarget));

return pkg?.path;
Expand Down