Skip to content

Enabling ClangCL compilation testing #55784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
StefanStojanovic wants to merge 2 commits into from
Closed

Enabling ClangCL compilation testing #55784

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
241e4a6
deps: enforce MSVC in node-gyp on Windows
StefanStojanovic Oct 25, 2024
758aaee
deps: define V8_PRESERVE_MOST as no-op on Windows
StefanStojanovic Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
deps: define V8_PRESERVE_MOST as no-op on Windows 
It's causing linker errors with node.lib in node-gyp and potentially
breaks other 3rd party tools
  • Loading branch information
@StefanStojanovic
StefanStojanovic committed Nov 8, 2024
commit 758aaee340fe790ee6647e87dd71a9e92edf559e
4 changes: 4 additions & 0 deletions deps/v8/include/v8config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -581,11 +581,15 @@ path. Add it with -I<path> to the command line
// functions.
// Use like:
// V8_NOINLINE V8_PRESERVE_MOST void UnlikelyMethod();
#if V8_OS_WIN
# define V8_PRESERVE_MOST
#else
#if V8_HAS_ATTRIBUTE_PRESERVE_MOST
# define V8_PRESERVE_MOST __attribute__((preserve_most))
#else
# define V8_PRESERVE_MOST /* NOT SUPPORTED */
#endif
#endif


// A macro (V8_DEPRECATED) to mark classes or functions as deprecated.
Expand Down