Skip to content

test: ignore unrelated events in FS watch tests #55605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduh95 merged 3 commits into from
Nov 6, 2024
Merged

test: ignore unrelated events in FS watch tests #55605

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
38f4ed7
fs: ignore unrelated events in watch tests
Ceres6 Oct 30, 2024
43f81a6
Update test/parallel/test-fs-watch-recursive-add-file-to-new-folder.js
Ceres6 Oct 31, 2024
2a5af5f
fixup! Update test/parallel/test-fs-watch-recursive-add-file-to-new-f…
Ceres6 Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update test/parallel/test-fs-watch-recursive-add-file-to-new-folder.js 
Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
@Ceres6 @lpinca
Ceres6 and lpinca authored Oct 31, 2024
commit 43f81a6e05d576f4e7016d0777e87bb386112df8
1 change: 0 additions & 1 deletion test/parallel/test-fs-watch-recursive-add-file-to-new-folder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ function doWatch() {
watcher.on('change', function(event, filename) {
if (filename === childrenRelativePath) {
assert.strictEqual(event, 'rename');
assert.ok(filename === path.basename(filePath) || filename === childrenRelativePath);
watcher.close();
watcherClosed = true;
}
Expand Down