Skip to content

stream: propagate AbortSignal reason #55473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Oct 22, 2024
Merged

stream: propagate AbortSignal reason #55473

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48a15eb
stream: propagate AbortSignal reason
marvinroger Oct 20, 2024
ed0d894
test: check the pipeline AbortSignal reason is propagated
marvinroger Oct 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: check the pipeline AbortSignal reason is propagated
  • Loading branch information
@marvinroger
marvinroger committed Oct 20, 2024
commit ed0d894c3a634696f5f8bcaa0f6dfe74177c65e7
4 changes: 3 additions & 1 deletion test/parallel/test-stream-pipeline.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1344,12 +1344,13 @@ tmpdir.refresh();

{
const ac = new AbortController();
const reason = new Error('Reason');
const r = Readable.from(async function* () {
for (let i = 0; i < 10; i++) {
await Promise.resolve();
yield String(i);
if (i === 5) {
ac.abort();
ac.abort(reason);
}
}
}());
Expand All @@ -1362,6 +1363,7 @@ tmpdir.refresh();
});
const cb = common.mustCall((err) => {
assert.strictEqual(err.name, 'AbortError');
assert.strictEqual(err.cause, reason);
assert.strictEqual(res, '012345');
assert.strictEqual(w.destroyed, true);
assert.strictEqual(r.destroyed, true);
Expand Down