Skip to content

esm: optimize string checks and slicing with direct index access #55435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mertcanaltin wants to merge 2 commits into from
Closed

esm: optimize string checks and slicing with direct index access #55435

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c36de3
esm: optimize string checks and slicing with direct index access
Oct 17, 2024
5b77adb
revert slice
Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
revert slice
  • Loading branch information
Mert Can Altin Mert Can Altin
Mert Can Altin authored and Mert Can Altin committed Oct 17, 2024
commit 5b77adbb5d409cda82c1ec5f96dc40290e522e96
3 changes: 2 additions & 1 deletion lib/internal/modules/esm/fetch_module.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ const {
ObjectPrototypeHasOwnProperty,
PromisePrototypeThen,
SafeMap,
StringPrototypeSlice,
} = primordials;
const {
Buffer: { concat: BufferConcat },
Expand Down Expand Up @@ -248,7 +249,7 @@ async function isLocalAddress(hostname) {
hostname[0] === '[' &&
hostname[hostname.length - 1] === ']'
) {
hostname = hostname.slice(1, -1);
hostname = StringPrototypeSlice(hostname, 1, -1);
}
const addr = await dnsLookup(hostname, { order: 'verbatim' });
const ipv = addr.family === 4 ? 'ipv4' : 'ipv6';
Expand Down