Skip to content

src: simplify string_bytes with views #54876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Sep 12, 2024
Merged

src: simplify string_bytes with views #54876

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6101478
src: simplify string_bytes with views
Sep 10, 2024
7336a55
restore comment
Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
restore comment
  • Loading branch information
Daniel Lemire
Daniel Lemire committed Sep 10, 2024
commit 7336a55561ada0b235ce146e6e5e8cd1fc8ce5f8
2 changes: 1 addition & 1 deletion src/string_bytes.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,7 @@ size_t StringBytes::Write(Isolate* isolate,
nbytes = written_len;
} else {
// The input does not follow the WHATWG forgiving-base64 specification
// adapted for base64url
// (adapted for base64url with + and / replaced by - and _).
// https://infra.spec.whatwg.org/#forgiving-base64-decode
nbytes = nbytes::Base64Decode(
buf,
Expand Down