Skip to content

deps: allow amaro to be externalizable #54646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mhdawson wants to merge 5 commits into from
Closed

deps: allow amaro to be externalizable #54646

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a5a4049
deps: allow amaro to be externalizable
mhdawson Aug 29, 2024
a276828
Update src/node_builtins.cc
mhdawson Sep 3, 2024
70154e9
squash: address review comments
mhdawson Sep 3, 2024
3e9f641
squash: address comments
mhdawson Sep 3, 2024
865ac33
Update src/node_metadata.h
mhdawson Sep 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
squash: address review comments 
Signed-off-by: Michael Dawson <midawson@redhat.com>
  • Loading branch information
@mhdawson
mhdawson committed Sep 3, 2024
commit 70154e921780dcafd0a35fdc2b0430934caa1399
2 changes: 2 additions & 0 deletions src/node_metadata.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,9 +127,11 @@ Metadata::Versions::Versions() {
cjs_module_lexer = CJS_MODULE_LEXER_VERSION;
uvwasi = UVWASI_VERSION_STRING;

#ifndef NODE_SHARED_BUILTIN_AMARO_DIST_INDEX_PATH
Comment thread
legendecas marked this conversation as resolved.
#if HAVE_AMARO
amaro = AMARO_VERSION;
#endif
#endif

#if HAVE_OPENSSL
openssl = GetOpenSSLVersion();
Expand Down