Skip to content

test: refactor test-whatwg-webstreams-encoding to be shorter #54569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 3 commits into from
Sep 19, 2024
Merged

test: refactor test-whatwg-webstreams-encoding to be shorter #54569

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
07a43f7
test: refactor test-whatwg-webstreams-encoding to be shorter
hidaviddong Aug 26, 2024
bcb414d
fix: add missing semicolon
hidaviddong Aug 27, 2024
9738074
fix: add stack trace in forEach loop
hidaviddong Aug 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: add stack trace in forEach loop
  • Loading branch information
@hidaviddong
hidaviddong committed Aug 29, 2024
commit 97380745ad6bf502e823bc4dd27b6ea75e9a289a
14 changes: 10 additions & 4 deletions test/parallel/test-whatwg-webstreams-encoding.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,11 @@ const kEuro = Buffer.from([0xe2, 0x82, 0xac]).toString();
assert.strictEqual(tds.ignoreBOM, false);
['encoding', 'fatal', 'ignoreBOM', 'readable', 'writable'].forEach((getter) => {
assert.throws(
() => Reflect.get(TextDecoderStream.prototype, getter, {}),
{ name: 'TypeError', message: /Cannot read private member/ }
() => Reflect.get(TextDecoderStream.prototype, getter, {}), {
name: 'TypeError',
message: /Cannot read private member/,
stack: new RegExp(`at get ${getter}`)
}
);
});
}
Expand All @@ -73,8 +76,11 @@ const kEuro = Buffer.from([0xe2, 0x82, 0xac]).toString();
assert.strictEqual(tds.encoding, 'utf-8');
['encoding', 'readable', 'writable'].forEach((getter) => {
assert.throws(
() => Reflect.get(TextDecoderStream.prototype, getter, {}),
{ name: 'TypeError', message: /Cannot read private member/ }
() => Reflect.get(TextDecoderStream.prototype, getter, {}), {
name: 'TypeError',
message: /Cannot read private member/,
stack: new RegExp(`at get ${getter}`)
}
);
});
}