Skip to content

doc: improve the process for landing a PR #54564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jakecastelli wants to merge 4 commits into from
Closed

doc: improve the process for landing a PR #54564

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
63c5b97
doc: improve the process for landing a PR
jakecastelli Aug 26, 2024
e03feec
Update doc/contributing/collaborator-guide.md
jakecastelli Aug 26, 2024
272ca49
Update doc/contributing/collaborator-guide.md
jakecastelli Aug 26, 2024
d8d2f7d
Update doc/contributing/collaborator-guide.md
jakecastelli Aug 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions doc/contributing/collaborator-guide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,6 +540,9 @@ The TSC serves as the final arbiter where required.
landing. If you are unsure exactly how to format the commit messages, use
the commit log as a reference. See [this commit][commit-example] as an
example.
6. Ideally check the recent commits on `main` to evaluate any potentially
risk or breakage that may happen, e.g. when two or more PRs both modified
the same subsystem or related subsystem(s).
Comment thread
jakecastelli marked this conversation as resolved.
Outdated
Comment thread
jakecastelli marked this conversation as resolved.
Outdated

For pull requests from first-time contributors, be
[welcoming](#welcoming-first-time-contributors). Also, verify that their git
Expand Down