Skip to content

tty: initialize winSize array with values #54281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Aug 11, 2024
Merged

tty: initialize winSize array with values #54281

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e0ef434
tty: initialize winSize array with values
targos Aug 9, 2024
e3b3a02
fixup! tty: initialize winSize array with values
targos Aug 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
tty: initialize winSize array with values 
Assigning to a holey array in the native layer may crash if it has
getters that throw.

Refs: #54186
  • Loading branch information
@targos
targos committed Aug 9, 2024
commit e0ef43414ef8d8a387d70641670c9ac86cc7efb7
4 changes: 2 additions & 2 deletions lib/tty.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ function WriteStream(fd) {
// Ref: https://github.com/nodejs/node/pull/1771#issuecomment-119351671
this._handle.setBlocking(true);

const winSize = new Array(2);
const winSize = [0, 0];
const err = this._handle.getWindowSize(winSize);
if (!err) {
this.columns = winSize[0];
Expand All @@ -131,7 +131,7 @@ WriteStream.prototype.hasColors = hasColors;
WriteStream.prototype._refreshSize = function() {
const oldCols = this.columns;
const oldRows = this.rows;
const winSize = new Array(2);
const winSize = [0, 0];
const err = this._handle.getWindowSize(winSize);
if (err) {
this.emit('error', new ErrnoException(err, 'getWindowSize'));
Expand Down