Skip to content

net: exclude ipv6 loopback addresses from server.listen #54264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 10 commits into from
Aug 23, 2024
Merged

net: exclude ipv6 loopback addresses from server.listen #54264

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9e65b33
net: exclude ipv6 loopback addresses from server.listen
Aug 8, 2024
804842d
net: changed the replacing of the dns module with a proper mock
Aug 8, 2024
5dec579
dns: removed copyright from new test and fixed broken one
Aug 9, 2024
bbf4e0b
dns: added automated test to check the error emission in lookupAndListen
Aug 9, 2024
6a5f988
dns: fixed the broken test. On mac it is failing with a different code
Aug 9, 2024
1896a8e
net: checking the whole range of ipv6 link-back addresses
Aug 10, 2024
97d8fc3
net: bridging native uv_inet_pton to js to parse ip to binary buffer
puskin Aug 19, 2024
195b631
test: update case of comment in a test
Aug 19, 2024
0f8eb48
test: updated the message when ipv6 is not enabled for link-local test
Aug 19, 2024
f04cc46
net: formatted cares_wrap.cc to fix linting issue
puskin Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
net: formatted cares_wrap.cc to fix linting issue
  • Loading branch information
@puskin
puskin committed Aug 20, 2024
commit f04cc46f55696b518898e694caf6c34264bad332
16 changes: 7 additions & 9 deletions src/cares_wrap.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1572,15 +1572,15 @@ void ConvertIpv6StringToBuffer(const FunctionCallbackInfo<Value>& args) {
unsigned char dst[16]; // IPv6 addresses are 128 bits (16 bytes)

if (uv_inet_pton(AF_INET6, *ip, dst) != 0) {
isolate->ThrowException(
v8::Exception::Error(
isolate->ThrowException(v8::Exception::Error(
String::NewFromUtf8(isolate, "Invalid IPv6 address").ToLocalChecked()));
return;
}

Local<Object> buffer = node::Buffer::Copy(
isolate,
reinterpret_cast<const char*>(dst), sizeof(dst)).ToLocalChecked();
Local<Object> buffer =
node::Buffer::Copy(
isolate, reinterpret_cast<const char*>(dst), sizeof(dst))
.ToLocalChecked();
args.GetReturnValue().Set(buffer);
}

Expand Down Expand Up @@ -1920,10 +1920,8 @@ void Initialize(Local<Object> target,
SetMethod(context, target, "getaddrinfo", GetAddrInfo);
SetMethod(context, target, "getnameinfo", GetNameInfo);
SetMethodNoSideEffect(context, target, "canonicalizeIP", CanonicalizeIP);
SetMethodNoSideEffect(context,
target,
"convertIpv6StringToBuffer",
ConvertIpv6StringToBuffer);
SetMethodNoSideEffect(
context, target, "convertIpv6StringToBuffer", ConvertIpv6StringToBuffer);

SetMethod(context, target, "strerror", StrError);

Expand Down