Skip to content

benchmark: use assert.ok instead of assert #54176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Aug 4, 2024
Merged

benchmark: use assert.ok instead of assert #54176

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a976f3c
benchmark: use assert.ok instead of assert
RafaelGSS Aug 2, 2024
5d58bf4
fixup! apply cr suggestions
RafaelGSS Aug 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! apply cr suggestions
  • Loading branch information
@RafaelGSS
RafaelGSS committed Aug 2, 2024
commit 5d58bf4d0121576c0ef4e72ffb0e533c52dc0dee
6 changes: 3 additions & 3 deletions benchmark/buffers/buffer-iterate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,15 +31,15 @@ function main({ size, type, method, n }) {
function benchFor(buffer, n) {
for (let k = 0; k < n; k++) {
for (let i = 0; i < buffer.length; i++) {
assert.ok(buffer[i] === 0);
assert.strictEqual(buffer[i], 0);
}
}
}

function benchForOf(buffer, n) {
for (let k = 0; k < n; k++) {
for (const b of buffer) {
assert.ok(b === 0);
assert.strictEqual(b, 0);
}
}
}
Expand All @@ -50,7 +50,7 @@ function benchIterator(buffer, n) {
let cur = iter.next();

while (!cur.done) {
assert.ok(cur.value === 0);
assert.strictEqual(cur.value, 0);
cur = iter.next();
}

Expand Down