Skip to content

doc: make some parameters optional in tracingChannel.traceCallback #54068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
deokjinkim wants to merge 1 commit into from
Closed

doc: make some parameters optional in tracingChannel.traceCallback #54068

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
doc: make some parameters optional in tracingChannel.traceCallback 
Plus, add missing `position` parameter to CJS example.
  • Loading branch information
@deokjinkim
deokjinkim committed Jul 27, 2024
commit 149b8b6354cdbd7677131b341401c171abb91d5a
4 changes: 2 additions & 2 deletions doc/api/diagnostics_channel.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -872,7 +872,7 @@ channels.tracePromise(async () => {
});
```

#### `tracingChannel.traceCallback(fn, position, context, thisArg, ...args)`
#### `tracingChannel.traceCallback(fn[, position[, context[, thisArg[, ...args]]]])`

<!-- YAML
added:
Expand Down Expand Up @@ -927,7 +927,7 @@ const channels = diagnostics_channel.tracingChannel('my-channel');
channels.traceCallback((arg1, callback) => {
// Do something
callback(null, 'result');
}, {
}, 1, {
some: 'thing',
}, thisArg, arg1, callback);
```
Expand Down