Skip to content

readline: fix unresolved promise on abortion #54030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DanielVenable wants to merge 3 commits into from
Closed

readline: fix unresolved promise on abortion #54030

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
80750e0
readline: fix unresolved promise on abortion
DanielVenable Jul 25, 2024
cab60dc
readline: fix js-lint errors
DanielVenable Jul 25, 2024
30387cf
readline: fix test so it tests aborting a question with both ctrl+C a…
DanielVenable Jan 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
readline: fix test so it tests aborting a question with both ctrl+C a… 
…nd ctrl+D
  • Loading branch information
@DanielVenable
DanielVenable committed Jan 29, 2025
commit 30387cf01b5f064deb7b5187b7b5f4043c9603b0
4 changes: 2 additions & 2 deletions test/parallel/test-readline-promises-interface.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -951,12 +951,12 @@ for (let i = 0; i < 12; i++) {
rli.close();
}

// Aborting a question with ctrl+D
// Aborting a question with ctrl+C
{
const [rli, fi] = getInterface({ terminal: true });
assert.rejects(rli.question('hello?'), { name: 'AbortError' })
.then(common.mustCall());
fi.emit('keypress', '.', { ctrl: true, name: 'd' });
fi.emit('keypress', '.', { ctrl: true, name: 'c' });
}

// Aborting a question with ctrl+D
Expand Down