Skip to content

test_runner: mock_loader resolve the cjs and esm formats respectively. #53846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduh95 merged 10 commits into from
Aug 6, 2024
Merged

test_runner: mock_loader resolve the cjs and esm formats respectively. #53846

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
44aa3e3
test_runner: replace cjs resolve to defaultResolve
syi0808 Jul 14, 2024
729a8ac
test_runner: divert resolve logic by type
syi0808 Jul 14, 2024
4a26832
test_runner: get format from parentURL as default or pass specifier a…
syi0808 Jul 15, 2024
45e4ea7
test_runner: test change to using exist file
syi0808 Jul 17, 2024
4d3247e
test_runner: use common.spawnPromisified instead of child_process
syi0808 Jul 17, 2024
61439ba
test_runner: use resolveFilename instead of createRequire
syi0808 Jul 17, 2024
45fb6b1
test_runner: remove module extension from imported file in fixture
syi0808 Jul 18, 2024
98870be
refactor: if to optional chaining
syi0808 Aug 3, 2024
a6ad04e
refactor: test move to module-mocking
syi0808 Aug 3, 2024
83adb9a
formatting
syi0808 Aug 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test_runner: use common.spawnPromisified instead of child_process
  • Loading branch information
@syi0808
syi0808 committed Jul 21, 2024
commit 4d3247e20732f39def42d61ec53983fffb566408
5 changes: 2 additions & 3 deletions test/parallel/test-runner-mocking.js
View file
Open in desktop
Comment thread
syi0808 marked this conversation as resolved.
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
'use strict';
const common = require('../common');
const child = require('child_process');
const assert = require('node:assert');
const { mock, test } = require('node:test');
const fixtures = require('../common/fixtures');
Expand Down Expand Up @@ -1057,8 +1056,8 @@ test('setter() fails if getter options is true', (t) => {
}, /The property 'options\.setter' cannot be used with 'options\.getter'/);
});

test.only('wrong import syntax should throw error after module mocking.', () => {
const { stdout, stderr } = child.spawnSync(
test('wrong import syntax should throw error after module mocking.', async () => {
const { stdout, stderr } = await common.spawnPromisified(
Comment thread
syi0808 marked this conversation as resolved.
Outdated
process.execPath,
[
'--experimental-test-module-mocks',
Expand Down