Skip to content

fs: ensure consistency for mkdtemp in both fs and fs/promises #53776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Jul 23, 2024
+1 −8
Merged

fs: ensure consistency for mkdtemp in both fs and fs/promises #53776

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fs: ensure consistency for mkdtemp in both fs and fs/promises 
Port changes for mkdtemp from lib/fs.js to lib/internal/fs/promise.js,
ensuring consistent behavior.

Refs: #51078
  • Loading branch information
@YieldRay
YieldRay committed Jul 9, 2024
commit ac88084263a23484b8535bba73df6663a024d302
9 changes: 1 addition & 8 deletions lib/internal/fs/promises.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1177,15 +1177,8 @@ async function mkdtemp(prefix, options) {
prefix = getValidatedPath(prefix, 'prefix');
warnOnNonPortableTemplate(prefix);

let path;
if (typeof prefix === 'string') {
path = `${prefix}XXXXXX`;
} else {
path = Buffer.concat([prefix, Buffer.from('XXXXXX')]);
}

return await PromisePrototypeThen(
binding.mkdtemp(path, options.encoding, kUsePromises),
binding.mkdtemp(prefix, options.encoding, kUsePromises),
undefined,
handleErrorFromBinding,
);
Expand Down