Skip to content

timers: test timeout NaN warning in promises version #53622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduh95 merged 2 commits into from
Jul 22, 2024
Merged

timers: test timeout NaN warning in promises version #53622

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d13fbaf
timers: test promises timeout NaN
Jun 28, 2024
8074052
Update test/parallel/test-timers-nan-duration-warning-promises.js
benjamingr Jun 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update test/parallel/test-timers-nan-duration-warning-promises.js 
Co-authored-by: Chengzhong Wu <legendecas@gmail.com>
  • Loading branch information
@benjamingr @legendecas
benjamingr and legendecas authored Jun 28, 2024
commit 807405268741a6b58a9f4e7141d78f4b0ee00807
2 changes: 1 addition & 1 deletion test/parallel/test-timers-nan-duration-warning-promises.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,4 @@ process.once('warning', common.mustCall((warning) => {
assert.strictEqual(warning.name, 'TimeoutNaNWarning');
}));

setTimeout(NaN).catch(common.mustNotCall());
setTimeout(NaN).then(common.mustCall(), common.mustNotCall());