Skip to content

test: extend env for test-node-output-errors #53535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Jun 23, 2024
Merged

test: extend env for test-node-output-errors #53535

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: extend env for test-node-output-errors 
Extend, rather than replace, `env` for `test-node-output-errors` so
that `node` binaries that need `LD_LIBRARY_PATH`, `LIBPATH` or
`DYLD_LIBRARY_PATH` can run.
  • Loading branch information
@richardlau
richardlau committed Jun 21, 2024
commit 83e297b0947d8749c67a6d0f99872b8a1318ab0c
4 changes: 1 addition & 3 deletions test/parallel/test-node-output-errors.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ import { describe, it } from 'node:test';
import { pathToFileURL } from 'node:url';

const skipForceColors =
process.config.variables.icu_gyp_path !== 'tools/icu/icu-generic.gyp' ||
process.config.variables.node_shared_openssl ||
(common.isWindows && (Number(os.release().split('.')[0]) !== 10 || Number(os.release().split('.')[2]) < 14393)); // See https://github.com/nodejs/node/pull/33132


Expand Down Expand Up @@ -76,7 +74,7 @@ describe('errors output', { concurrency: !process.env.TEST_PARALLEL }, () => {
];
for (const { name, transform = defaultTransform, env, skip = false } of tests) {
it(name, { skip }, async () => {
await snapshot.spawnAndAssert(fixtures.path(name), transform, { env });
await snapshot.spawnAndAssert(fixtures.path(name), transform, { env: { ...env, ...process.env } });
});
}
});