Skip to content

test: fix flaky http-end-throw-socket-handling #5342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
santigimeno wants to merge 1 commit into from
Closed

test: fix flaky http-end-throw-socket-handling #5342

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: fix flaky http-end-throw-socket-handling 
This test was sometimes failing on `OS X` because the internal timeout
was fired before the test completed. The reason was that sometimes some
of the connections were taking longer to be established. Removing the
timeout seems to fix the issue.
  • Loading branch information
@santigimeno
santigimeno committed Feb 20, 2016
commit 211a37d13e096da198493755e4f5f2d9b7f77e0e
5 changes: 0 additions & 5 deletions test/parallel/test-http-end-throw-socket-handling.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,6 @@ server.listen(common.PORT, function() {
}
});

setTimeout(function() {
process.removeListener('uncaughtException', catcher);
throw new Error('Taking too long!');
}, common.platformTimeout(1000)).unref();

process.on('uncaughtException', catcher);
var errors = 0;
function catcher() {
Expand Down