Skip to content

process: port on-exit-leak-free to core #53239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 20 commits into from
Jul 11, 2024
Merged

process: port on-exit-leak-free to core #53239

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
fb74bb6
process: port on-exit-leak-free to core
H4ad May 31, 2024
bd3e04c
add test with worker threads
H4ad Jun 1, 2024
4cc7d31
extract code to own file and added license
H4ad Jun 1, 2024
2889b9f
referece the correct file on license
H4ad Jun 1, 2024
f2b8e64
add docs about new methods
H4ad Jun 1, 2024
f7ff57a
fix type issue for ref and improved validation
H4ad Jun 1, 2024
999687e
fix type of event
H4ad Jun 1, 2024
ce99d95
remove unused type
H4ad Jun 1, 2024
8dd7e80
update license builder
H4ad Jun 2, 2024
cafc2ab
update docs to fix a misunderstanding
H4ad Jun 2, 2024
f155afc
fix lint
H4ad Jun 2, 2024
dccd8c1
use more primordials & rename test file
H4ad Jun 2, 2024
c6978a0
more primordials and prototype pollution safe-guards
H4ad Jun 3, 2024
5842163
try address comments about gc
H4ad Jun 7, 2024
c3bb74a
changed stability status
H4ad Jun 10, 2024
2f887dc
added experimental warnings
H4ad Jun 10, 2024
893c79f
typo fixes and trailing line
H4ad Jun 17, 2024
5aab8fb
lazy load finalization
H4ad Jun 24, 2024
c094345
attempt to improve the docs
H4ad Jun 24, 2024
8002996
remove stdout usages
H4ad Jun 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
remove stdout usages
  • Loading branch information
@H4ad
H4ad committed Jul 11, 2024
commit 8002996d5ef8b1b7c59faba515573390eabe0986
6 changes: 2 additions & 4 deletions doc/api/process.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2042,7 +2042,7 @@ This function remove the register of the object from the finalization
registry, so the callback will not be called anymore.

```cjs
const { finalization, stdout } = require('node:process');
const { finalization } = require('node:process');

// Please make sure that the function passed to finalization.register()
// does not create a closure around unnecessary objects.
Expand All @@ -2058,7 +2058,6 @@ function setup() {
const myDisposableObject = {
dispose() {
// Free your resources synchronously
stdout.write('disposed.\n');
},
};

Expand All @@ -2074,7 +2073,7 @@ setup();
```

```mjs
import { finalization, stdout } from 'node:process';
import { finalization } from 'node:process';

// Please make sure that the function passed to finalization.register()
// does not create a closure around unnecessary objects.
Expand All @@ -2090,7 +2089,6 @@ function setup() {
const myDisposableObject = {
dispose() {
// Free your resources synchronously
stdout.write('disposed.\n');
},
};

Expand Down