Skip to content

src: nuke deprecated and un-used enum members in OptionEnvvarSettings #53079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Nov 5, 2024
Merged

src: nuke deprecated and un-used enum members in OptionEnvvarSettings #53079

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
src: nuke deprecated and un-used enum members in OptionEnvvarSettings 
Delete deprecated an never used enum options `kAllowedInEnvironment`
and `kDisallowedInEnvironment` in `OptionEnvvarSettings`

Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>
  • Loading branch information
@juanarbol
juanarbol committed May 21, 2024
commit 7a8725895c445cb5f40a6e77fb3189d1e9408568
4 changes: 0 additions & 4 deletions src/node.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,10 +374,6 @@ enum OptionEnvvarSettings {
// Disallow the options to be set via the environment variable, like
// `NODE_OPTIONS`.
kDisallowedInEnvvar = 1,
// Deprecated, use kAllowedInEnvvar instead.
kAllowedInEnvironment = kAllowedInEnvvar,
// Deprecated, use kDisallowedInEnvvar instead.
kDisallowedInEnvironment = kDisallowedInEnvvar,
};

// Process the arguments and set up the per-process options.
Expand Down
4 changes: 2 additions & 2 deletions typings/internalBinding/options.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ export interface OptionsBinding {
aliases: Map<string, string[]>;
};
envSettings: {
kAllowedInEnvironment: 0;
kDisallowedInEnvironment: 1;
kAllowedInEnvvar: 0;
kDisallowedInEnvvar: 1;
};
noGlobalSearchPaths: boolean;
shouldNotRegisterESMLoader: boolean;
Expand Down