Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
c60cd67
test: skip test for dynamically linked OpenSSL
richardlau Apr 15, 2024
678641f
deps: V8: cherry-pick d15d49b09dc7
Bo98 Apr 2, 2024
6689a98
http: remove closeIdleConnections function while calling server close
kumarrishav Apr 2, 2024
5186e45
test: deflake test-http-regr-gh-2928
lpinca Sep 9, 2023
5cec2ef
test: reduce the number of requests and parsers
lpinca Oct 20, 2023
5e93eae
doc: add release key for marco-ippolito
marco-ippolito Mar 28, 2024
e28316d
deps: update nghttp2 to 1.58.0
nodejs-github-bot Nov 2, 2023
3c9dbbf
deps: update nghttp2 to 1.59.0
nodejs-github-bot Feb 1, 2024
1b6fa70
deps: update nghttp2 to 1.60.0
nodejs-github-bot Mar 5, 2024
a9f3b9d
deps: update nghttp2 to 1.61.0
nodejs-github-bot Apr 16, 2024
b56f66e
deps: update simdutf to 4.0.9
nodejs-github-bot Mar 9, 2024
be30309
deps: update simdutf to 5.0.0
lemire Mar 20, 2024
5114cbe
deps: update simdutf to 5.2.3
anonrig Apr 4, 2024
209823d
deps: update simdutf to 5.2.4
nodejs-github-bot Apr 13, 2024
052b0ba
deps: upgrade npm to 10.5.1
npm-cli-bot Apr 7, 2024
b199889
deps: update corepack to 0.26.0
nodejs-github-bot Mar 12, 2024
7a8c7b6
deps: update ada to 2.7.7
nodejs-github-bot Mar 12, 2024
9500817
deps: update acorn to 8.11.2
nodejs-github-bot Oct 31, 2023
c86550e
deps: update acorn-walk to 8.3.0
nodejs-github-bot Oct 29, 2023
dddb7eb
deps: update acorn-walk to 8.3.1
nodejs-github-bot Dec 10, 2023
12f28f3
deps: update acorn to 8.11.3
nodejs-github-bot Jan 2, 2024
2c53ff3
deps: update acorn-walk to 8.3.2
nodejs-github-bot Jan 22, 2024
71616e8
node-api: make tsfn accept napi_finalize once more
gabrielschulhof Mar 9, 2024
8fd5a35
deps: upgrade npm to 10.5.2
npm-cli-bot Apr 12, 2024
28c0c78
deps: update ngtcp2 and nghttp3
jasnell Dec 26, 2023
1aa9da4
deps: add nghttp3/**/.deps to .gitignore
lpinca Jan 8, 2024
3034968
deps: update ngtcp2 to 1.1.0
nodejs-github-bot Jan 22, 2024
1f489a3
deps: update ngtcp2 to 1.2.0
nodejs-github-bot Jan 31, 2024
78f84eb
deps: update ngtcp2 to 1.3.0
nodejs-github-bot Feb 26, 2024
7f5dd44
deps: upgrade npm to 10.7.0
npm-cli-bot May 1, 2024
14e857b
deps: update corepack to 0.28.0
nodejs-github-bot Apr 23, 2024
e4ea2db
deps: update c-ares to 1.28.1
nodejs-github-bot Apr 4, 2024
af3e320
deps: update ada to 2.7.8
nodejs-github-bot Apr 14, 2024
755399d
deps: update zlib to 1.3.0.1-motley-24342f6
nodejs-github-bot Mar 19, 2024
1152d7f
deps: update zlib to 1.3.0.1-motley-24c07df
nodejs-github-bot Mar 27, 2024
0c260e1
deps: update zlib to 1.3.0.1-motley-7d77fb7
nodejs-github-bot Apr 17, 2024
1147fee
doc: remove ableist language from crypto
10xLaCroixDrinker Mar 17, 2024
351ef18
test: v8: Add test-linux-perf-logger test suite
lukealbao Oct 25, 2023
e5fc8ec
test: skip v8-updates/test-linux-perf
targos Oct 7, 2023
d9d9e62
src: avoid draining platform tasks at FreeEnvironment
legendecas Jan 8, 2024
64903b1
2024-05-21, Version 18.20.3 'Hydrogen' (LTS)
richardlau May 16, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: deflake test-http-regr-gh-2928
Hard code the value of the host parameter to `common.localhostIPv4` in
`server.listen()` and `net.connect()`. This

1. ensures that the client `socket._handle` is not reinitialized during
   connection due to the family autodetection algorithm, preventing
   `parser.consume()` from being called with an invalid `socket._handle`
   parameter.
2. works around an issue in the FreeBSD 12 machine where the stress test
   is run where some sockets get stuck after connection.

PR-URL: #49574
Backport-PR-URL: #52384
Closes: #49565
Fixes: #49564
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
lpinca authored and richardlau committed Apr 17, 2024
commit 5186e453d9f5e3e711020ea0ece93b4be667f06e
4 changes: 2 additions & 2 deletions test/sequential/test-http-regr-gh-2928.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ function execAndClose() {
const parser = parsers.pop();
parser.initialize(HTTPParser.RESPONSE, {});

const socket = net.connect(common.PORT);
const socket = net.connect(common.PORT, common.localhostIPv4);
socket.on('error', (e) => {
// If SmartOS and ECONNREFUSED, then retry. See
// https://github.com/nodejs/node/issues/2663.
Expand Down Expand Up @@ -57,7 +57,7 @@ const server = net.createServer(function(c) {
c.end('HTTP/1.1 200 OK\r\n\r\n', function() {
c.destroySoon();
});
}).listen(common.PORT, execAndClose);
}).listen(common.PORT, common.localhostIPv4, execAndClose);

process.on('exit', function() {
assert.strictEqual(gotResponses, COUNT);
Expand Down